Refactor client's node-check invocation timeout default value. #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalaBalaYi
requested review from
workingloong,
samplise and
majieyue
as code owners
BalaBalaYi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
- Coverage 81.21% 81.20% -0.01%
==========================================
Files 238 238
Lines 23173 23179 +6
==========================================
+ Hits 18819 18822 +3
- Misses 4354 4357 +3 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
merged commit 227940f
into
intelligent-machine-learning:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The client invocation timeout must > node check timeout(300s) .
Why are the changes needed?
To optimize the node-check logic.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and training.