Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce check fault timeout and check straggler timeout to 1 sec #1439

Conversation

majieyue
Copy link
Collaborator

@majieyue majieyue commented Jan 14, 2025

reduce the check fault and straggler nodes timeout to 1s, so we can make sure next nodecheck round the fault nodes and straggler nodes are synced up

@BalaBalaYi BalaBalaYi added the enhancement New feature or request label Jan 14, 2025
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Jan 14, 2025
Copy link
Collaborator

@BalaBalaYi BalaBalaYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (cd10a18) to head (2f5adcb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   81.19%   81.15%   -0.05%     
==========================================
  Files         238      238              
  Lines       23167    23169       +2     
==========================================
- Hits        18811    18803       -8     
- Misses       4356     4366      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majieyue majieyue merged commit b09b7f7 into intelligent-machine-learning:master Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants