Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo RayJobSubmitter in ray_job_submitter.py #1320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Peefy
Copy link

@Peefy Peefy commented Nov 5, 2024

What changes were proposed in this pull request?

I discovered this error while browsing and learning the code, so I raised a PR to fix it

Why are the changes needed?

Typos in code can affect people's learning and use of it

Does this PR introduce any user-facing change?

Yes, this means that once people have used it in past versions, they also need to modify it together.

How was this patch tested?

Unit test in CI.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (de6c5b1) to head (0c8f775).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   80.46%   80.46%           
=======================================
  Files         222      222           
  Lines       20740    20740           
=======================================
  Hits        16688    16688           
  Misses       4052     4052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant