Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty node issue after master failover #1317

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

Re add relaunch worker node info back to job_nodes in JobManager during 'list' operation.

Why are the changes needed?

Fix empty node issue after master failover.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT and training(with worker failover + master failover).

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Nov 4, 2024
@BalaBalaYi BalaBalaYi changed the title Fix no target node case Fix empty node issue after master failover Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (a55b1cf) to head (2e30831).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/master/node/dist_job_manager.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   80.46%   80.45%   -0.01%     
==========================================
  Files         222      222              
  Lines       20728    20740      +12     
==========================================
+ Hits        16678    16687       +9     
- Misses       4050     4053       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BalaBalaYi BalaBalaYi merged commit de6c5b1 into intelligent-machine-learning:master Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants