Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor diagnosis manager #1302

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

samplise
Copy link
Collaborator

What changes were proposed in this pull request?

Refactor diagnosis manager.

Why are the changes needed?

Complete the diagnose manager implmenetation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test

from dlrover.python.diagnosis.common.diagnose_action import DiagnoseActionQueue


class JobContext:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need annotations.

@@ -0,0 +1,16 @@
from dlrover.python.diagnosis.common.diagnose_action import DiagnoseActionQueue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change module name to job_context.py.

def next_actions(self, rank):
return self._action_queue.next_actions(rank)

def update_context(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should not exist or not be public.

dlrover/python/master/node/job.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 87.41935% with 117 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (186783e) to head (43dce77).

Files with missing lines Patch % Lines
...lrover/python/diagnosis/common/diagnosis_action.py 53.24% 36 Missing ⚠️
dlrover/python/elastic_agent/torch/training.py 46.87% 17 Missing ⚠️
dlrover/python/master/node/dist_job_manager.py 79.72% 15 Missing ⚠️
dlrover/python/master/node/worker.py 63.15% 14 Missing ⚠️
dlrover/python/master/node/training_node.py 81.57% 7 Missing ⚠️
...rover/python/master/diagnosis/diagnosis_manager.py 85.18% 4 Missing ⚠️
dlrover/python/master/node/local_job_manager.py 84.61% 4 Missing ⚠️
dlrover/python/master/node/ps.py 84.61% 4 Missing ⚠️
...rover/python/elastic_agent/config/launch_config.py 93.87% 3 Missing ⚠️
.../python/elastic_agent/diagnosis/diagnosis_agent.py 92.30% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
+ Coverage   80.52%   80.57%   +0.05%     
==========================================
  Files         222      226       +4     
  Lines       20707    21266     +559     
==========================================
+ Hits        16674    17136     +462     
- Misses       4033     4130      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants