-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor diagnosis manager #1302
base: master
Are you sure you want to change the base?
[WIP] Refactor diagnosis manager #1302
Conversation
dlrover/python/master/node/job.py
Outdated
from dlrover.python.diagnosis.common.diagnose_action import DiagnoseActionQueue | ||
|
||
|
||
class JobContext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need annotations.
dlrover/python/master/node/job.py
Outdated
@@ -0,0 +1,16 @@ | |||
from dlrover.python.diagnosis.common.diagnose_action import DiagnoseActionQueue | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change module name to job_context.py
.
dlrover/python/master/node/job.py
Outdated
def next_actions(self, rank): | ||
return self._action_queue.next_actions(rank) | ||
|
||
def update_context(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should not exist or not be public.
What changes were proposed in this pull request?
Refactor diagnosis manager.
Why are the changes needed?
Complete the diagnose manager implmenetation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test