【WIP】add pod diagnosis feature #1219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. monitor pod periodically 2. diagnosis long pending pods based on the monitoring data Signed-off-by: xiluo <[email protected]>
xiaochaoren
requested review from
workingloong,
samplise,
BalaBalaYi and
majieyue
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
- Coverage 80.41% 80.31% -0.11%
==========================================
Files 217 219 +2
Lines 19463 19567 +104
==========================================
+ Hits 15652 15715 +63
- Misses 3811 3852 +41 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
requested changes
Aug 5, 2024
| @@ -78,6 +82,22 @@ def get_timestamp(self) -> int: | |||
| def get_type(self) -> str: | |||
| return DiagnosisDataType.CHIPMETRICES | |||
|
|
|||
| class K8sPodData(DiagnosisData): | |||
| def __init__(self, timestamp: int, pods: List[V1Pod]): | |||
There was a problem hiding this comment.
Better not involve 'V1Pod' in common package(or user should add 'kubernetes' deps in their env).
| from dlrover.python.scheduler.job import JobArgs | ||
|
|
||
|
|
||
| class PodMonitor(object): |
There was a problem hiding this comment.
This impl is duplicated with _monitor_nodes in dist_job_manager.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
automatically recover the job from the long pending problem
Does this PR introduce any user-facing change?
No.
How was this patch tested?