-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sockct close v2 #1168
base: master
Are you sure you want to change the base?
Add sockct close v2 #1168
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
- Coverage 79.67% 79.66% -0.02%
==========================================
Files 210 210
Lines 18681 18709 +28
==========================================
+ Hits 14885 14905 +20
- Misses 3796 3804 +8 ☔ View full report in Codecov by Sentry. |
@workingloong How to supply exception testing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You can patch the method of socket in your test cases to raise an OSError like dlrover/dlrover/python/tests/test_elastic_training_agent.py Lines 202 to 207 in 0c18cc5
|
@yangrudan Please resolve the conflicts. |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By run unit test.