Fixes some tests/bugs, and adds a build with sanitizers #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently the sanitizers only work with clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems most of the tests were not handling the case where the input size was zero; to be sure these don't misbehave, I've extended those tests to test arrays of size zero. In doing so, I found a few bugs in that handling which should be fixed by this patch.
In addition, this patch adds a new build option to the makefile
test_asan, which enabled address sanitizer and undefined behavior sanitizer. This currently only works with clang; GCC seems to show a clearly invalid issue, whereas clang shows no issue there. I also resolved all of the issues found by the undefined behavior sanitizer in this patch.I wanted to add a CI run that ran the sanitizers, but it seems it would be too slow using both the sanitizers and in the SDE.