Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vp9e: accept MFX_FRAMETYPE_IDR and MFX_FRAMETYPE_REF #330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xhaihao
Copy link
Contributor

@xhaihao xhaihao commented May 23, 2024

MFX_FRAMETYPE_IDR or MFX_FRAMETYPE_REF can be ORed to mfxEncodeCtrl::FrameType for other codecs(e.g AV1) when calling MFXVideoENCODE_EncodeFrameAsync(), let's do the same for VP9.

This makes the below command work fine.

ffmpeg -hwaccel qsv -hwaccel_output_format qsv -i input.h264 -force_key_frames:v source -forced_idr 1 -c:v vp9_qsv -f null -

@Sherry-Lin Sherry-Lin requested a review from leyu-yao May 24, 2024 07:51
@xhaihao xhaihao changed the title vp9d: accept MFX_FRAMETYPE_IDR and MFX_FRAMETYPE_REF vp9e: accept MFX_FRAMETYPE_IDR and MFX_FRAMETYPE_REF May 27, 2024
MFX_FRAMETYPE_IDR or MFX_FRAMETYPE_REF can be ORed to
mfxEncodeCtrl::FrameType for other codecs(e.g AV1) when calling
MFXVideoENCODE_EncodeFrameAsync(), let's do the same for VP9.

This makes the below command work fine.

ffmpeg -hwaccel qsv -hwaccel_output_format qsv -i input.h264 -force_key_frames:v source \
-forced_idr 1 -c:v vp9_qsv -f null -

Signed-off-by: Haihao Xiang <[email protected]>
@xhaihao xhaihao force-pushed the vp9-ctrl-frametype branch from c06e465 to bbc484d Compare May 27, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant