-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gamma: Align data type in computation with the declaration of the helper #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuan14
changed the title
Resolve the FP64 issue in the gamma operators on ARC
gamma: Align data type in computation with class definition
Aug 28, 2024
fengyuan14
changed the title
gamma: Align data type in computation with class definition
gamma: Align data type in computation with the declaration of the helpe
Aug 28, 2024
fengyuan14
changed the title
gamma: Align data type in computation with the declaration of the helpe
gamma: Align data type in computation with the declaration of the helper
Aug 28, 2024
fengyuan14
reviewed
Aug 29, 2024
test/xpu/skip_list_arc.py
Outdated
Comment on lines
11
to
13
"test_ops_xpu.py": ( | ||
"test_compare_cpu_digamma_xpu_float32", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't need
fengyuan14
approved these changes
Aug 30, 2024
ZhiweiYan-96
pushed a commit
that referenced
this pull request
Aug 30, 2024
…per (#836) Resolve the FP64 issue in the gamma operators on ARC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the FP64 issue in the gamma operators on ARC.