Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamma: Align data type in computation with the declaration of the helper #836

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

xytintel
Copy link
Contributor

Resolve the FP64 issue in the gamma operators on ARC.

@fengyuan14 fengyuan14 changed the title Resolve the FP64 issue in the gamma operators on ARC gamma: Align data type in computation with class definition Aug 28, 2024
@fengyuan14 fengyuan14 changed the title gamma: Align data type in computation with class definition gamma: Align data type in computation with the declaration of the helpe Aug 28, 2024
@fengyuan14 fengyuan14 changed the title gamma: Align data type in computation with the declaration of the helpe gamma: Align data type in computation with the declaration of the helper Aug 28, 2024
@xytintel
Copy link
Contributor Author

image

Comment on lines 11 to 13
"test_ops_xpu.py": (
"test_compare_cpu_digamma_xpu_float32",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the skip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't need

@fengyuan14 fengyuan14 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 7d1dd47 Aug 30, 2024
3 checks passed
@fengyuan14 fengyuan14 deleted the xyt/gamma_double branch August 30, 2024 01:11
ZhiweiYan-96 pushed a commit that referenced this pull request Aug 30, 2024
…per (#836)

Resolve the FP64 issue in the gamma operators on ARC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants