-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved some of the UT codes and cleaned the skip list. #799
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
@@ -90,7 +90,7 @@ def fn_to_gradcheck(*flat_input_and_params): | |||
@wrapSwapTensorsTest() | |||
def _test_to(self, device, dtype, module_info, training, swap, set_grad): | |||
module_cls = module_info.module_cls | |||
devices = ['xpu'] | |||
devices = ['cpu', 'xpu'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the meaning of adding cpu
to devices
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the case is to compare cpu and xpu op output, we aligned with cuda. If didn't add "cpu" , the case will error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok to align with cuda but why the test will fail if no cpu in the devices list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the order of testing will affect the results
Pull request was converted to draft
Improved some of the UT codes and cleaned the skip list.