SYCL: Alternative solution to avoid runtime error of launching kernel on xpu:1 when que… #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rying SYCL kernel bundle ahead Signed-off-by: Feng Yuan <[email protected]>
|
@fengyuan14 , by the way, please give some detailed information here. |
EikanWang
reviewed
Aug 19, 2024
Comment on lines
+19
to
+20
| auto kbundle = ::sycl::get_kernel_bundle<::sycl::bundle_state::executable>( | ||
| ctx, {dev}, {kid}); |
There was a problem hiding this comment.
@fengyuan14 , could you help submit a GitHub issue to github.com/intel/llvm and then add some comments here to link the issue to be submitted?
Overall, LGTM.
fengyuan14
changed the title
chuanqi129
reviewed
Aug 19, 2024
| - name: Run XPU OP Examples | ||
| if: contains(inputs.ut, 'op_example') || github.event_name == 'schedule' | ||
| - name: Run XPU OP Regressions test | ||
| if: contains(inputs.ut, 'op_regression') || github.event_name == 'schedule' |
There was a problem hiding this comment.
Where are those test case come from? From previously example?
There was a problem hiding this comment.
Yes, Just renaming them.
|
|
||
| class TestOperationOnDevice1(TestCase): | ||
| def test_sum_on_device1(self, dtype=torch.float): | ||
| if torch.xpu.device_count() >= 2: |
There was a problem hiding this comment.
For single card node, this test will be skipped by default, right?
Signed-off-by: Feng Yuan <[email protected]>
Co-authored-by: Wang, Chuanqi <[email protected]>
chuanqi129
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
LGTM. CC: @RUIJIEZHONG66166 @mengfei25 to aware this UT structure change
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rying SYCL kernel bundle ahead
The kernel won't be built for devices except for the first device. Launching kernel on devices except for the first device will raise runtime error. Here is an alternative as a temporary solution to provide an extra hint to SYCL runtime. intel/llvm#15127