Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc: Comment failure of test_variable_sequence_xpu_float16 with justification after evaluation #693

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hjhee
Copy link
Contributor

@hjhee hjhee commented Aug 5, 2024

Certain step in current LSTM implementation returns incorrect result consistently. It is believed that the root cause should be in Op addmm using oneDNN matmul implementation.

@hjhee hjhee changed the title check failure case: test_variable_sequence_xpu_float64 Check failure case: test_variable_sequence_xpu_float16 Aug 6, 2024
@fengyuan14 fengyuan14 changed the title Check failure case: test_variable_sequence_xpu_float16 Comment justification on failure of test_variable_sequence_xpu_float16 after evaluation Aug 6, 2024
@fengyuan14 fengyuan14 changed the title Comment justification on failure of test_variable_sequence_xpu_float16 after evaluation Comment failure of test_variable_sequence_xpu_float16 with justification after evaluation Aug 6, 2024
@hjhee hjhee mentioned this pull request Aug 6, 2024
@fengyuan14 fengyuan14 changed the title Comment failure of test_variable_sequence_xpu_float16 with justification after evaluation arc: Comment failure of test_variable_sequence_xpu_float16 with justification after evaluation Aug 7, 2024
@fengyuan14 fengyuan14 marked this pull request as draft August 7, 2024 01:12
@fengyuan14
Copy link
Contributor

Arc specific. We are discussing to separate skip lists for different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants