[CI] UT logs post op and artifact #671
Conversation
.github/workflows/_linux_ut.yml
Outdated
| @@ -28,6 +28,12 @@ on: | |||
| type: string | |||
| default: 'linux.idc.xpu' | |||
| description: Runner label | |||
| expected_fail_num: | |||
There was a problem hiding this comment.
Do we really need this parameter?
| - name: UT Test Results Check | ||
| if: ${{ inputs.expected_fail_num }} | ||
| shell: bash | ||
| run: | |
There was a problem hiding this comment.
Can we abstract this step as a script and put it into .github/scripts? and in this step, we not only check the test pass or not, but also show the failure cases and logs directly
.github/workflows/_linux_ut.yml
Outdated
| - name: Upload Inductor XPU UT Data | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: Inductor-XPU-UT-Data-${{ github.event.pull_request.number || github.sha }} |
There was a problem hiding this comment.
Change the name to Torch-XPU-UT-Log-xxx. And we can move the upload step after the result check step with if: always()
.github/workflows/_linux_ut.yml
Outdated
| @@ -120,7 +122,7 @@ jobs: | |||
| if [[ "$xpu_case" != *"*"* && "$xpu_case" != *.so && "$xpu_case" != *.a ]]; then | |||
| case_name=$(basename "$xpu_case") | |||
| echo "Testing ${case_name} ..." | |||
| "$xpu_case" --gtest_output=xml:"$TEST_REPORTS_DIR"/"$case_name".xml | |||
| "$xpu_case" --gtest_output=xml:"$TEST_REPORTS_DIR"/"$case_name".xml 2>&1 | tee ${{ github.workspace }}/ut_log/binary_UT_${ut_suite}_${case_name}_Test.log | |||
There was a problem hiding this comment.
add one more folder under ut_log, for example ut_log/binary_ut/${case_name}...log
.github/workflows/_linux_ut.yml
Outdated
| @@ -142,3 +144,31 @@ jobs: | |||
| test_cmd="${test_cmd} test_xpu.py" | |||
| fi | |||
| eval $test_cmd | |||
There was a problem hiding this comment.
How about inductor test logs? will we upload those logs too? Seems the pytorch ut test log under ./test/test-reports/ by default
.github/workflows/_linux_ut.yml
Outdated
| $contains_status | ||
| cd ${{ github.workspace }}/ut_log | ||
| bash ut_result_check.sh ${ut_suite} | ||
| done |
There was a problem hiding this comment.
Better to add a space line at the end of file
|
build failure need rebase the code to the latest main |
|
Please wait for preci fixing. |
|
@RUIJIEZHONG66166 Can we transfer the status of this PR to ready for review? And can this PR address the issue #1166? |
chuanqi129
changed the title
No description provided.