Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate failure cases after having XPU implementation #651

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Reevaluate failure cases after having XPU implementation #651

merged 7 commits into from
Jul 30, 2024

Conversation

chunhuanMeng
Copy link
Contributor

@chunhuanMeng chunhuanMeng commented Jul 25, 2024 •
edited
Loading

Pass now:

  • test_fn_gradgrad_norm_inf_xpu_complex128
  • test_fn_gradgrad_norm_inf_xpu_complex128
  • test_fn_grad_nn_functional_group_norm_xpu_float64
  • test_fn_gradgrad_nn_functional_group_norm_xpu_float64
  • test_fn_grad_linalg_vector_norm_xpu_complex128

Fail bacause use rrelu_with_noise_cpu:

  • test_fn_grad_nn_functional_rrelu_xpu_float64
  • test_fn_gradgrad_nn_functional_rrelu_xpu_float64

"rrelu_with_noise_" is not in fallback list, so error is "NotImplementedError: The operator 'aten::rrelu_with_noise_' is not currently implemented for the XPU device":

  • test_inplace_grad_nn_functional_rrelu_xpu_float64
  • test_inplace_gradgrad_nn_functional_rrelu_xpu_float64

Additional Context
#271

@fengyuan14 fengyuan14 changed the title Delete some cases from skip list Reevaluate failure cases after having XPU implementation Jul 26, 2024
@fengyuan14 fengyuan14 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit bd16501 Jul 30, 2024
2 checks passed
@fengyuan14 fengyuan14 deleted the meng_fix branch July 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengyuan14 fengyuan14 fengyuan14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunhuanMeng @fengyuan14