Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Summary #648

Merged
merged 8 commits into from
Aug 12, 2024
Merged

Enhance Summary #648

merged 8 commits into from
Aug 12, 2024

Conversation

RUIJIEZHONG66166
Copy link
Contributor

No description provided.

Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have a small scope test by using ondemand test workflow?

@RUIJIEZHONG66166
Copy link
Contributor Author

The ondemand test results: https://github.com/intel/torch-xpu-ops/actions/runs/10109174514

@chuanqi129
Copy link
Contributor

The ondemand test results: https://github.com/intel/torch-xpu-ops/actions/runs/10109174514

Got it, thanks @RUIJIEZHONG66166. I have checked the summary excel file, overall LGTM, some comments with the summary format, take the you shared on-demand test as example,

  1. Can we merge the different suite acc/perf summary sheets into one unite summary sheet?
  2. Can we move the summary sheet as the first/default sheet of the excel file?

@RUIJIEZHONG66166
Copy link
Contributor Author

The ondemand test results: https://github.com/intel/torch-xpu-ops/actions/runs/10109174514

Got it, thanks @RUIJIEZHONG66166. I have checked the summary excel file, overall LGTM, some comments with the summary format, take the you shared on-demand test as example,

  1. Can we merge the different suite acc/perf summary sheets into one unite summary sheet?
  2. Can we move the summary sheet as the first/default sheet of the excel file?

Different suite of acc or perf can be merged into one acc or perf summary sheet as a enhancement later.
Summary sheet needs the data of detail sheet when generating report. Its not suitable to move it as the first.

@fengyuan14
Copy link
Contributor

Please wait for preci fixied.

@RUIJIEZHONG66166 RUIJIEZHONG66166 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 1bb0a1e Aug 12, 2024
3 checks passed
@RUIJIEZHONG66166 RUIJIEZHONG66166 deleted the ruijie/enhance_summary branch August 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants