Update pin_memory implementation follow stock pytorch change #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: majing <[email protected]>
dvrogozh
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Emm... Update and delete implementation are different things :). Can you, please, explain (in PR description) why implementation is not needed anymore on torch-xpu-ops side? Also, did you check that pytorch/pytorch#126491 continues to work?
Make sense. We will add comments. Please see the latest description. |
fengyuan14
approved these changes
Jul 24, 2024
|
Thank you for updating description. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch implemented device agnostic aten::is_pinned and aten::_pin_memory in latest main.
pytorch/pytorch@8963623