unittest: Handle op_db to align xfail defined by CUDA #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuan14
changed the title
|
Please resolve the conflicts. |
|
Please,
|
fengyuan14
reviewed
Aug 5, 2024
| # Mismatched elements: 2 / 125 (1.6%) | ||
| # Greatest absolute difference: 0.001953125 at index (2, 0, 0) (up to 0.001 allowed) | ||
| # Greatest relative difference: 0.007568359375 at index (2, 0, 0) (up to 0.001 allowed) | ||
| "test_compare_cpu_cumprod_xpu_bfloat16", |
There was a problem hiding this comment.
We have got it in line 172. Please remove it.
fengyuan14
reviewed
Aug 5, 2024
test/xpu/run_test_with_skip.py
Outdated
| # Mismatched elements: 2 / 125 (1.6%) | ||
| # Greatest absolute difference: 0.001953125 at index (2, 0, 0) (up to 0.001 allowed) | ||
| # Greatest relative difference: 0.007568359375 at index (2, 0, 0) (up to 0.001 allowed) | ||
| "test_compare_cpu_cumprod_xpu_bfloat16", |
|
Please address the comments. |
…-ops into unexpected_xfail
fengyuan14
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional coverage of PyTorch XPU operator is aligned with CUDA. So we are gradually align test scope with CUDA. The PR is to handle op_db to align xfail configuration. It helps us reduce efforts to triage failures which are expected.
#593