Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten::polar and its variants #606

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Add aten::polar and its variants #606

merged 8 commits into from
Jul 30, 2024

Conversation

yucai-intel
Copy link
Contributor

No description provided.

@fengyuan14
Copy link
Contributor

Looks we have better dtype coverage than expected?
image

@yucai-intel
Copy link
Contributor Author

yucai-intel commented Jul 22, 2024

The data types are consistent with those supported by CUDA.
Screenshot 2024-07-22 152455

@fengyuan14
Copy link
Contributor

fengyuan14 commented Jul 24, 2024

The data types are consistent with those supported by CUDA. Screenshot 2024-07-22 152455

The error log is saying unexpected data type is supported in Polar backward. Do yo know which operator is invoked in backward? Can you have an investigation, if the backward op supports bfloat16, does not aligned with CUDA, you can skip the case and add error log and list the backward operator as comments.

@yucai-intel
Copy link
Contributor Author

Polar's backward is calculated using complex(), which does not support bfloat16, so the test of this datatype is skipped.

@fengyuan14
Copy link
Contributor

o

If we align with CUDA, CUDA should fail as well?

@yucai-intel
Copy link
Contributor Author

Cuda fails with same error:
RuntimeError: Expected both inputs to be Half, Float or Double tensors but got BFloat16 and BFloat16.

yaml/xpu_functions.yaml Outdated Show resolved Hide resolved
@fengyuan14 fengyuan14 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 36dfe23 Jul 30, 2024
2 checks passed
@fengyuan14 fengyuan14 deleted the polar branch July 30, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants