Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression issue and revert the change of checkIndexTensorTypes usage #597

Merged
merged 4 commits into from
Aug 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed regression issue to change the tolerance and revert checkIndexT…
…ensorTypes usage

Signed-off-by: Cheng Penghui <[email protected]>
PenghuiCheng committed Aug 8, 2024
commit dde5e37038ca24aeb7b471958ba895463c7e9ac9
2 changes: 1 addition & 1 deletion src/ATen/native/xpu/sycl/IndexingUtils.h
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@ static std::tuple<Tensor, int64_t, int64_t, int64_t> computeLinearIndex(
static std::
tuple<Tensor, Tensor, int64_t, int64_t, int64_t, std::vector<int64_t>>
makeLinearIndex(Tensor self, IOptTensorListRef orig, bool check_range) {
checkIndexTensorTypes(orig);
checkIndexTensorTypes(orig, /*allow_int*/ true);
// first expand BoolTensor (masks) or ByteTensor (masks) into 1 or more
// LongTensors
auto indices = expandTensors(self, orig);
7 changes: 0 additions & 7 deletions test/xpu/run_test_with_skip.py
Original file line number Diff line number Diff line change
@@ -1302,7 +1302,6 @@ def launch_test(test_case, skip_list=None, exe_list=None):

# test_indexing


skip_list = (
# CPU bias cases
# It is kernel assert on XPU implementation not exception on host.
@@ -1315,11 +1314,6 @@ def launch_test(test_case, skip_list=None, exe_list=None):
# https://github.com/intel/torch-xpu-ops/issues/461
"test_index_put_src_datatype_xpu_float8_e5m2",
"test_index_put_src_datatype_xpu_float8_e4m3fn",

# Regression after PyTorch update
# http://github.com/intel/torch-xpu-ops/issues/549
# IndexError: tensors used as indices must be long, byte or bool tensors.
"test_index_ind_dtype_xpu",
)
res += launch_test("test_indexing_xpu.py", skip_list)

@@ -2938,7 +2932,6 @@ def launch_test(test_case, skip_list=None, exe_list=None):

# test_convolution


skip_list = (
# XPU unsupport ops, skip.
"test_cudnn_convolution_relu_xpu_float16",