Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten::histogram and variant #569

Merged
merged 21 commits into from
Jul 25, 2024
Merged

Add aten::histogram and variant #569

merged 21 commits into from
Jul 25, 2024

Conversation

majing921201
Copy link
Contributor

CPU/MPS only ops

@majing921201
Copy link
Contributor Author

majing921201 commented Jul 12, 2024

two cases failed:
SampleInput(input=tensor([-6.7103, 5.7013, 0.7920, 2.8814, -4.1030], device='xpu:0'), args=(tensor([-6.7103, 5.7013, 0.7920], device='xpu:0'),), kwargs={'weight': None, 'density': False}, broadcasts_input=False, name='')

SampleInput(input=6.362441917740258, args=(tensor([ 6.3624, -3.1650, 7.6229, 4.4501], device='xpu:0',
dtype=torch.float64),), kwargs={'weight': None, 'density': False}, broadcasts_input=False, name='')

cases are not reasonable, for out-of-order bin.
1, pytorch doc requires increasing bin
image
2, CPU implemented kernel with std::upper_bound, which also requires increasing sequence

@majing921201 majing921201 marked this pull request as draft July 17, 2024 06:05
Signed-off-by: Ma, Jing1 <[email protected]>
Signed-off-by: Ma, Jing1 <[email protected]>
@majing921201 majing921201 marked this pull request as ready for review July 17, 2024 06:47
@majing921201
Copy link
Contributor Author

pytorch/pytorch#130916

@fengyuan14 fengyuan14 marked this pull request as draft July 19, 2024 02:08
@fengyuan14 fengyuan14 marked this pull request as ready for review July 19, 2024 02:09
@fengyuan14 fengyuan14 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit fcaa34c Jul 25, 2024
2 checks passed
@fengyuan14 fengyuan14 deleted the majing/histogram branch July 25, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants