Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip float8 dtype UT cases and workaround #1211

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Skip float8 dtype UT cases and workaround #1211

merged 6 commits into from
Dec 27, 2024

Conversation

PenghuiCheng
Copy link
Contributor

@PenghuiCheng PenghuiCheng commented Dec 25, 2024 •
edited
Loading

  1. Skip float8 dtype UT cases
  2. workaround: skip some cases because UT random failure

@PenghuiCheng
Skip float8 dtype UT cases
fd09fa4 
Signed-off-by: Cheng, Penghui <[email protected]>
daisyden
daisyden approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@daisyden daisyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PenghuiCheng PenghuiCheng changed the title Skip float8 dtype UT cases Skip float8 dtype UT cases and workaround Dec 26, 2024
@PenghuiCheng PenghuiCheng mentioned this pull request Dec 26, 2024
Open
@PenghuiCheng PenghuiCheng added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 826389a Dec 27, 2024
3 checks passed
@PenghuiCheng PenghuiCheng deleted the penghuic/skip_float8_UT branch December 27, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daisyden daisyden daisyden approved these changes

@xytintel xytintel Awaiting requested review from xytintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PenghuiCheng @daisyden