Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip lists for LNL, BGM and MTL devices #1187

Merged
merged 5 commits into from
Dec 25, 2024
Merged

Conversation

PenghuiCheng
Copy link
Contributor

@PenghuiCheng PenghuiCheng commented Dec 20, 2024

Add skip lists for LNL, BGM and MTL devices

Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, by the way, could we unify all skip list py files as one config file? such as a yaml/json file?

-common
  -common
    -test_file1
      -test_case1
      -test_case2
    -test_file2
      -test_case3
      -...
  -linux
    -test_file3
      -test_case4
      -...
  -windows
    -test_file4
      -test_case5
      -...
-lnl
  -common
    -test_file1
      -test_case1
      -test_case2
    -test_file2
      -test_case3
      -...
  -linux
    -test_file3
      -test_case4
      -...
  -windows
    -test_file4
      -test_case5
      -...
-bmg
  -...
-pvc
  -...
-arc
  -...
-...

For example, the lnl win skip list should be the common.comon + common.windows + lnl.common + lnl.windows. It will help to us to understand skip lists more clear, how do you think?

@PenghuiCheng PenghuiCheng changed the title Add skip list for LNL and BGM devices Add skip lists for LNL, BGM and MTL devices Dec 24, 2024
@PenghuiCheng PenghuiCheng added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit 0f48ac0 Dec 25, 2024
3 checks passed
@PenghuiCheng PenghuiCheng deleted the penghuic/LNL_BMG_skip branch December 25, 2024 01:10
ZhiweiYan-96 pushed a commit that referenced this pull request Jan 16, 2025
Add skip lists for LNL, BGM and MTL devices

---------

Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants