-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aten::_nested_from_padded #1045
base: main
Are you sure you want to change the base?
Conversation
Hi @daisyden, could you please help port the following UTs to torch-xpu-ops? Thanks! |
} | ||
|
||
template <typename T> | ||
void remove_padding_kernelLauncher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the mixing naming. In PyTorch, usually, we have launch_xxx_kernel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
} else { | ||
AT_ERROR("Only support fp32/fp16 for padded input"); | ||
} | ||
return at::detail::make_tensor<at::native::NestedTensorImpl>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we have not upstreamed DispatchKey::NestedTensorXPU
. It should not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fengyuan14 , I created #1141 to keep track of PRs related to NestedTensor
support for xpu.
I think we can leave Nested Tensor related operators for now,
According to the time line, it is a bit tight for us to catch up 2.6, if we need upstream the dispatch key. We can treat it as an entire feature to support Nested Tensor in 2.7. @EikanWang Please comment and decide. |
_nested_from_padded