Add Windows CI #1028
Open
Add Windows CI #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuanqi129
reviewed
Dec 12, 2024
.github/workflows/pull.yml
Outdated
| @@ -35,6 +35,14 @@ jobs: | |||
| abi: 0 | |||
| ut: op_extended | |||
| runner: linux.idc.xpu | |||
|
|
|||
| preci-windows-build: | |||
There was a problem hiding this comment.
Suggested change
| preci-windows-build: | |
| preci-windows: |
.github/workflows/windows.yml
Outdated
There was a problem hiding this comment.
Rename to _winodws_ut.yml
.github/workflows/windows.yml
Outdated
| type: string | ||
| default: '' | ||
| description: UT scope. `op_regression,op_regression_dev1,op_extended,op_ut,torch_xpu` Delimiter is comma | ||
| abi: |
.github/workflows/windows.yml
Outdated
| runner: | ||
| required: true | ||
| type: string | ||
| default: 'linux.idc.xpu' |
There was a problem hiding this comment.
change the default value for windows
.github/workflows/windows.yml
Outdated
| USE_XPU: 1 | ||
|
|
||
| jobs: | ||
| Torch-XPU-Windows-Build: |
There was a problem hiding this comment.
Suggested change
| Torch-XPU-Windows-Build: | |
| Torch-XPU-Windows-UT: |
.github/workflows/windows.yml
Outdated
Comment on lines
103
to
109
| if ${{ inputs.abi }} == '0' ( | ||
| set _GLIBCXX_USE_CXX11_ABI=0 | ||
| echo "ABI=0" | ||
| ) else ( | ||
| set _GLIBCXX_USE_CXX11_ABI=1 | ||
| echo "ABI=1" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if ${{ inputs.abi }} == '0' ( | |
| set _GLIBCXX_USE_CXX11_ABI=0 | |
| echo "ABI=0" | |
| ) else ( | |
| set _GLIBCXX_USE_CXX11_ABI=1 | |
| echo "ABI=1" | |
| ) |
.github/workflows/windows.yml
Outdated
| ) | ||
| cd .. | ||
| Xcopy ..\torch-xpu-ops third_party\torch-xpu-ops /E/H/Y/F/I | ||
| ) |
There was a problem hiding this comment.
Add one more step to call install_xpu.bat
.github/workflows/windows.yml
Outdated
| call "C:\ProgramData\miniforge3\Scripts\activate.bat" | ||
| call conda activate windows_ci | ||
| call "C:\Program Files (x86)\Intel\oneAPI\pytorch-gpu-dev-0.5\oneapi-vars.bat" | ||
| call "C:\Program Files (x86)\Intel\oneAPI\ocloc\2024.2\env\vars.bat" |
There was a problem hiding this comment.
Suggested change
| call "C:\Program Files (x86)\Intel\oneAPI\ocloc\2024.2\env\vars.bat" |
.github/workflows/windows.yml
Outdated
| call "C:\ProgramData\miniforge3\Scripts\activate.bat" | ||
| call conda activate windows_ci | ||
| call "C:\Program Files (x86)\Intel\oneAPI\pytorch-gpu-dev-0.5\oneapi-vars.bat" | ||
| call "C:\Program Files (x86)\Intel\oneAPI\ocloc\2024.2\env\vars.bat" |
There was a problem hiding this comment.
Suggested change
| call "C:\Program Files (x86)\Intel\oneAPI\ocloc\2024.2\env\vars.bat" |
|
Hi @RUIJIEZHONG66166 , Please change the windows ci trigger condition as PR with windows label, you can follow the method in https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label. |
RUIJIEZHONG66166
added
os: Windows
RUIJIEZHONG66166
force-pushed
the
ruijie/add_windows_ci
branch
2 times, most recently
from
4951982 to
8a9d8a7
Compare
RUIJIEZHONG66166
force-pushed
the
ruijie/add_windows_ci
branch
2 times, most recently
from
9c0ba4f to
60006c5
Compare
RUIJIEZHONG66166
force-pushed
the
ruijie/add_windows_ci
branch
from
60006c5 to
41ad063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.