This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
deploy: test with Kubernetes 1.21 instead of 1.18 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
force-pushed
the
kubernetes-1.21-support
branch
from
7f1e9c8 to
f8cc2f7
Compare
|
A newer external-provisioner with kubernetes-csi/external-provisioner#635 is needed for block volumes. |
pohly
force-pushed
the
kubernetes-1.21-support
branch
2 times, most recently
from
497578d to
4a0d65a
Compare
pohly
changed the title
|
The new external-provisioner v2.2.2 should work. |
pohly
force-pushed
the
kubernetes-1.21-support
branch
from
dcd2e49 to
20775de
Compare
The deployments for 1.18 get removed in favor of testing with 1.21. For the two versions which get tested pre-merge, testing of both "production" and "testing" deployments gets restored the way it was originally intended (more tests on main worker, less on newly spawned worker). Kubernetes 1.21 has additional default values that we need to ignore when validating deployments.
pohly
force-pushed
the
kubernetes-1.21-support
branch
from
20775de to
89cee65
Compare
The new external-provisioner v2.2.0 supports storage capacity tracking with the v1beta1 API in Kubernetes >= 1.21. Our new deployment files for 1.21 and the operator enable that for 1.21, but not for 1.19 and 1.20 To simplify the sidecar update in the future, the hack/bump-image-versions.sh gets added which patches all locations were we define image versions. Unnecessary variables in pkg/apis/pmemcsi/v1beta1/deployment_types.go get removed because they were only used there and patching the file is simpler when there is only one variable per image.
Now that we actually can use the feature, the scheduler extensions are not needed anymore for Kubernetes >= 1.21.
pohly
force-pushed
the
kubernetes-1.21-support
branch
from
89cee65 to
7874146
Compare
|
Testing was successful, including full testing of the entire branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployments for 1.18 get removed in favor of testing with 1.21.
For the two versions which get tested pre-merge, testing of both
"production" and "testing" deployments gets restored the way it
was originally intended (more tests on main worker, less on newly
spawned worker).
Fixes: #978
Fixes: #982
Fixes: #856
Fixes: #730