Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Commit

Permalink
deploy: allow pod scheduling when webhook is down
Browse files Browse the repository at this point in the history
This is based on a risk assessment. There's no perfect solution.
  • Loading branch information
pohly committed Dec 20, 2020
1 parent a3ab180 commit a31615e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion deploy/kustomize/webhook/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ webhooks:
- key: pmem-csi.intel.com/webhook
operator: NotIn
values: ["ignore"]
failurePolicy: Fail
# For pods with PMEM volumes using late binding, not activating the
# scheduler extension is okayish (but see https://github.com/kubernetes-csi/external-provisioner/issues/544).
# It's worse for CSI ephemeral volumes because there is no recovery.
# Nonetheless, failing pod scheduling entirely when PMEM-CSI is down
# seems worse, so we let the scheduler continue despite failures.
failurePolicy: Ignore
clientConfig:
service:
name: pmem-csi-scheduler
Expand Down

0 comments on commit a31615e

Please sign in to comment.