Add listMappings command #366
Conversation
|
Please add the example's output in your commit message too. |
List all the mapping under a given path Example with the MusicLibrary form the Getting Started wiki : $ remote-process localhost 5000 listMappings /MusicLibrary/my_library/artists/IronMaiden /MusicLibrary/my_library/artists/IronMaiden [Directory:/home/fponcabx/pfw/install-examples/libraries, File:ironMaiden, File:ironMaiden] Signed-off-by: Florian Poncabaré <[email protected]>
Current coverage is 80.13%@@ master #366 diff @@
========================================
Files 211 211
Lines 7169 7188 +19
Methods 0 0
Branches 0 0
========================================
Hits 5760 5760
- Misses 1409 1428 +19
Partials 0 0
|
|
|
||
| for (string path : paths) { | ||
| string mapping; | ||
| if (getParameterMapping(path, mapping)) { |
There was a problem hiding this comment.
Can you check if you can dump only the terminal element. Today you are listing the full list of element. So to many element without control are listed. See under:
/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:HP Playback Volume
/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME/0 => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:'%1 Playback Volume'
/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG => Card:bytcrrt5640, Debug:
/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG/SWITCH => Card:bytcrrt5640, Debug:, Control:'Mono Playback Switch', Control:Mono Playback Switch
There was a problem hiding this comment.
What you seem to want isn't the terminal element (i.e. leaves, i.e. parameters) but the SubsystemObjects (the elements with an instantiation mapping).
Add the listMappings command which list all the mappings under a given path
Example with the MusicLibrary form the Getting Started wiki :
$ remote-process localhost 5000 listMappings /MusicLibrary/my_library/artists/IronMaiden
/MusicLibrary/my_library/artists/IronMaiden [Directory:/home/fponcabx/pfw/install-examples/libraries, File:ironMaiden, File:ironMaiden]
/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:HP Playback Volume
/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME/0 => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:'%1 Playback Volume'
/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG => Card:bytcrrt5640, Debug:
/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG/SWITCH => Card:bytcrrt5640, Debug:, Control:'Mono Playback Switch', Control:Mono Playback Switch