Use slice::align_to
#135
Merged
Use slice::align_to
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking that tensor data can be converted to a slice of `T`, we previously were checking the right things: is the length right? Is the alignment correct? Turns out there is a `std` function that does this for us: `slice::align_to`. Replacing the custom check with the `std` version should have no effect on the code other than clarity.
rahulchaphalkar
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking that tensor data can be converted to a slice of
T, we previously were checking the right things: is the length right? Is the alignment correct? Turns out there is astdfunction that does this for us:slice::align_to. Replacing the custom check with thestdversion should have no effect on the code other than clarity.