Add compile.sh to CI #939
Merged
Add compile.sh to CI #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Garra1980 we need to keep |
I agree, trying to see whether build is okay |
Garra1980
reviewed
Oct 24, 2024
|
|
||
| - name: Cache LLLVM-MLIR | ||
| id: cache-llvm-mlir | ||
| uses: actions/cache@v4 | ||
| env: | ||
| LLVM_CACHE_NUMBER: 1 # Increase to reset cache | ||
| LLVM_CACHE_NUMBER: 2 # Increase to reset cache |
There was a problem hiding this comment.
do we really need this one?
There was a problem hiding this comment.
while things may work if I revert it, there is no sense in reverting it
There was a problem hiding this comment.
the standard practice is to increase the counter every time we need the cache to be rebuilt
Garra1980
reviewed
Oct 24, 2024
scripts/compile.sh
Outdated
|
|
||
| cd $(dirname "$0")/.. | ||
|
|
||
| cmake -S . -B build -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_ZSTD=OFF "$@" |
There was a problem hiding this comment.
let's use gcc not clang as we do it currently
Garra1980
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj