Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VnniTransformation] Stop propagation on ops implementing CastOpInterface #917

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[VnniTransformation] Stop propagation on ops implementing CastOpInterface #917

merged 1 commit into from
Oct 9, 2024

Conversation

chencha3
Copy link
Contributor

@chencha3 chencha3 commented Oct 9, 2024

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@chencha3 chencha3 merged commit a37ed93 into main Oct 9, 2024
2 checks passed
@chencha3 chencha3 deleted the vnni_on_trunc_for_upstream branch October 9, 2024 21:46
@chencha3 chencha3 changed the title Stop propagation on ops implementing CastOpInterface [VnniTransformation] Stop propagation on ops implementing CastOpInterface Oct 9, 2024
chencha3 added a commit that referenced this pull request Oct 10, 2024
@chencha3
Refine #917, allow vnni propagation for castOps with same input and o…
3407e9c 
…utput bitwidth
chencha3 added a commit that referenced this pull request Oct 10, 2024
@chencha3
Refine #917, allow vnni propagation for bitcast-like Ops (#919)
9d73c3c 
Refine #917, allow vnni propagation for castOps with same input and output bitwidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garra1980 Garra1980 Garra1980 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chencha3 @Garra1980