Minor wording correction for order attribute #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garra1980
reviewed
Feb 16, 2024
docs/rfcs/XeTile.md
Outdated
| @@ -79,37 +79,37 @@ Attribute `padding` specifies the padding value for the out-of-boundary access. | |||
| ``` | |||
| `load_tile` needs to be used with the tile_mma. | |||
|
|
|||
| `load_tile` loads a tile with an `order` attribute. The `order` attribute affects the indexing order for the tile access, however, it doesn't change the logical representation of loading a 2D tile to a 2D vector. There is no need to reverse the order of vector length at the XeTile level regardless of the `order` attribute value. | |||
| `load_tile` loads a tile according to the tile's `order` attribute. Regardless of the `order` attribute value, the vector's dimensions must match exactly the Title's dimensions. | |||
There was a problem hiding this comment.
How about explicitly stating that order attribute reveals whether the base memref is in row-major or col-major order. It is only used to guide compiler for code generation and does not impact users' algorithm expression?
There was a problem hiding this comment.
fixed both comments.
I added the description in the init_tile, "The order must be consistent with the data layout specified by the memref represening the base matirx.".
Garra1980
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review these guidelines to help with the review process: