Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create XeGPU.md #674

Merged
merged 16 commits into from
Dec 15, 2023
Merged

Create XeGPU.md #674

merged 16 commits into from
Dec 15, 2023

Conversation

Jianhui-Li
Copy link
Contributor

initial empty file

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved
docs/rfcs/XeGPU.md Outdated Show resolved Hide resolved

## Notes

Currently, there is no lower-level GPU IR like NVVM available for the Intel GPU compiler toolchain. XeGPU dialect uses LLVM or SPIRV intrinsic to access advanced intel GPU instructions. When the lower-level software changes, we expect XeGPU lowering passes to change accordingly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For people not familar with NVVM, it may be better to give more detail on how the low level dialect looks like.
"GPU IR like NVVM available for the Intel GPU compiler toolchain" ->
"dialect for the Intel GPU compiler tool chain to represent GPU ops with values based on LLVM data types such as NVVM dialect for the Nvidia GPU compiler toolchain"

@silee2 silee2 marked this pull request as ready for review December 15, 2023 20:19
Copy link
Contributor

@silee2 silee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silee2 silee2 merged commit ca4e1db into intel:main Dec 15, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants