Fix Coverity issues

intel · Nov 13, 2023 · f05029e · f05029e
1 parent db7c272
commit f05029e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
@@ -990,10 +990,6 @@ mlir::LogicalResult DpasOp::verify() {
         "lhs and rhs rank does not match for dpas op, or their rank is not 3.");
   }
 
-  if (lhsRank < 3) {
-    return emitOpError("dpas op requires 3d vector. Rank is not 3");
-  }
-
   return mlir::success();
 }
 

diff --git a/lib/Dialect/XeTile/IR/XeTileOps.cpp b/lib/Dialect/XeTile/IR/XeTileOps.cpp
@@ -341,8 +341,6 @@ void LoadTileOp::print(mlir::OpAsmPrinter &printer) {
   printer << " { ";
   if ((*this)->getAttrs().size()) {
     if (getTransposeAttr()) {
-      if (printSep)
-        printer << ", ";
       printer << "transpose = ";
       getTransposeAttr().print(printer);
       printSep = true;

diff --git a/lib/Dialect/XeTile/Transforms/XeTileTiling.cpp b/lib/Dialect/XeTile/Transforms/XeTileTiling.cpp
@@ -155,6 +155,7 @@ struct SCFForOpPattern : public XeTileConversion<mlir::scf::ForOp> {
         adaptor.getStep(), adaptor.getInitArgs());
     mlir::Block *block = op.getBody();
     mlir::Block *newBlock = newOp.getBody();
+    newBlock->clear();
     rewriter.mergeBlocks(block, newBlock, newBlock->getArguments());
     rewriter.replaceOp(op, newOp);
     return mlir::success();