Coverity fixes (#922)

* Coverity fixes * Update SubviewOp.cpp * Update BlockingAnalysis.h * Update WgToSg.cpp * Update SubviewOp.cpp - pre-commit
intel · Oct 11, 2024 · 0fc4bb2 · 0fc4bb2
1 parent 15c3691
commit 0fc4bb2
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/lib/Dialect/Dist/Transforms/DistCoalesce.cpp b/lib/Dialect/Dist/Transforms/DistCoalesce.cpp
@@ -564,7 +564,6 @@ struct DistCoalescePass
                                 loc, nProcs, pRank, _sizes);
                         tOffs = defPart.getLOffsets();
                         tSizes = defPart.getLShape();
-                        bbIPnt = defPart;
                         auto nop = updateTargetPart(builder, e, tOffs, tSizes);
                         assert(!nop);
                       }

diff --git a/lib/Dialect/NDArray/IR/SubviewOp.cpp b/lib/Dialect/NDArray/IR/SubviewOp.cpp
@@ -433,8 +433,6 @@ findImmutableInsertSliceSource(::imex::ndarray::ImmutableInsertSliceOp iisOp,
     laterOffs.emplace_back(iisOffs);
     laterSizes.emplace_back(iisSizes);
   };
-
-  return {};
 }
 } // namespace
 

diff --git a/lib/Dialect/XeTile/Transforms/BlockingAnalysis.h b/lib/Dialect/XeTile/Transforms/BlockingAnalysis.h
@@ -49,6 +49,7 @@ class BlockingAnalysis {
 public:
   explicit BlockingAnalysis(std::shared_ptr<XeuArchInterface> uArch) {
     this->uArch = uArch;
+    this->target = nullptr;
   };
 
   mlir::LogicalResult run(mlir::Operation *op);

diff --git a/lib/Dialect/XeTile/Transforms/WgToSg.cpp b/lib/Dialect/XeTile/Transforms/WgToSg.cpp
@@ -519,7 +519,7 @@ class WGToSGArithConstantOpPattern
         value.value_end<mlir::Attribute>());
 
     llvm::SmallVector<mlir::Attribute> newValues;
-    for (int64_t i = 0; i < sgData[0] * sgData[1]; i++) {
+    for (int64_t i = 0; i < static_cast<int64_t>(sgData[0]) * sgData[1]; i++) {
       newValues.push_back(elems[i]);
     }