[Decode] Remove av1 decode from feature list on some platforms #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: intel#1852, intel#1832 Av1 decode needs filmgrain kernel support, and free kernel build will not support av1 decode. Signed-off-by: Xu, Zhengguo <[email protected]>
Jexu
force-pushed
the
br0_update_features
branch
from
870ffc9
to
4c0c803
Compare
Wouldn't it be more intuitive to set these to This would make libva not report AV1 decoding support in the so-called "free" driver, instead of crashing the video player or libavcodec when vaapi decoding is invoked. So as the downstream can fallback to using the software decoder gracefully. |
|
@Jexu ^ + https://trac.ffmpeg.org/ticket/11213 . IMHO Avoiding the crash itself should be part of the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1852, #1832
Av1 decode needs filmgrain kernel support, and free kernel build will not support av1 decode.