Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CUDA] Update UMF in UR to fix issue in LLVM #17034

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Feb 17, 2025

Update UMF to the commit:

    commit 5a515c56c92be75944c8246535c408cee7711114
    Author: Lukasz Dorau <[email protected]>
    Date:   Mon Feb 17 10:56:05 2025 +0100
    Merge pull request #1086 from vinser52/svinogra_l0_linking

to fix the issue in LLVM (SYCL/CUDA):

https://github.com/intel/llvm/issues/16944
[SYCL][CUDA] Nsys profiling broken after memory providers change

Moved from: oneapi-src/unified-runtime#2708

Fixes: #16944

@ldorau ldorau requested a review from a team as a code owner February 17, 2025 12:21
@ldorau
Copy link
Contributor Author

ldorau commented Feb 17, 2025

Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the issue in #16944 👍

@ldorau ldorau force-pushed the SYCL_CUDA_Update_UMF_in_UR_to_fix_issue_in_LLVM branch from 177389b to ce9298b Compare February 18, 2025 10:51
Update UMF to the commit:

commit 5a515c56c92be75944c8246535c408cee7711114
Author: Lukasz Dorau <[email protected]>
Date:   Mon Feb 17 10:56:05 2025 +0100
Merge pull request intel#1086 from vinser52/svinogra_l0_linking

to fix the issue in LLVM (SYCL/CUDA):

intel#16944
[SYCL][CUDA] Nsys profiling broken after memory providers change

Fixes: intel#16944

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the SYCL_CUDA_Update_UMF_in_UR_to_fix_issue_in_LLVM branch from ce9298b to 79f58e2 Compare February 19, 2025 09:18
@ldorau
Copy link
Contributor Author

ldorau commented Feb 19, 2025

@npmiller @omarahmed1111 please re-approve this PR moved from oneapi-src/unified-runtime#2708

@ldorau
Copy link
Contributor Author

ldorau commented Feb 20, 2025

@omarahmed1111 please re-approve this PR moved from oneapi-src/unified-runtime#2708

@pbalcer
Copy link
Contributor

pbalcer commented Feb 20, 2025

@intel/llvm-gatekeepers please merge

@steffenlarsen steffenlarsen merged commit e925b2b into intel:sycl Feb 20, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SYCL][CUDA] Nsys profiling broken after memory providers change
5 participants