[SYCL][DOC] Document -foffload-fp32-prec-div/sqrt options #17033
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
commented
Feb 17, 2025
| @@ -350,6 +350,18 @@ and not recommended to use in production environment. | |||
|
|
|||
| ## Other options | |||
|
|
|||
| **`-f[no-]offload-fp32-prec-sqrt`** | |||
There was a problem hiding this comment.
@gmlueck during writing this document I've realized, that there is a similar option already, that works only for CUDA and HIP. I believe, that these options should be merged under sycl-fp32-prec-sqrt name and div option should be renamed to sycl-fp32-prec-div (unless we want to deprecate sycl naming for them, which also might make sense in a certain cases). WDYT?
There was a problem hiding this comment.
I have no strong feelings on which option should remain (offload or sycl), but I do agree that we should merge these.
Signed-off-by: Sidorov, Dmitry <[email protected]>
This reverts commit 18c7cc9.
This was referenced Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.