[SYCL] Fix min/max known_identity<> wrong when -ffast-math is used. #17028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T> being incorrect when using -ffast-math. It works because we have a __FAST_MATH__ macro that is defined when that flag is used. Better, ould be to detect -fno-honor-infinities,. Opening a JIRA/discussion for that, but this is a big improvement in the interim.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Feb 18, 2025
| See https://github.com/intel/llvm/issues/13813 | ||
|
|
||
| -ffast-math implies -fno-honor-infinities. In this case, the known_identity | ||
| for sycl::minimum<T> cannot be inifinity (which will be 0), but must instead |
There was a problem hiding this comment.
Suggested change
| for sycl::minimum<T> cannot be inifinity (which will be 0), but must instead | |
| for sycl::minimum<T> cannot be infinity (which will be 0), but must instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically a workaround, this fixes the problem with
known_identity<minOp/maxOp>being incorrect when using-ffast-math. It works because we have a__FAST_MATH__macro that is defined when that flag is used. Better, would be to detect-fno-honor-infinities. Opening a JIRA/discussion for that, but this is a big improvement in the interim.See discussion #13813