[SYCL][NativeCPU] Fix kernel argument passing. #16995
Merged
+87
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
841df61 to
65e085a
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
65e085a to
b6809f3
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
b6809f3 to
6cb6f2d
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
6cb6f2d to
53101cd
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
53101cd to
1b9a2f8
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
1b9a2f8 to
1cabcee
Compare
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
1cabcee to
b24b8ff
Compare
We were reading the kernel arguments at kernel execution time, but kernel arguments are allowed to change between enqueuing and executing. Make sure to create a copy of kernel arguments ahead of time.
hvdijk
force-pushed
the
nativecpu-kernel-arguments
branch
from
b24b8ff to
10ccd68
Compare
coldav
approved these changes
Feb 19, 2025
kbenzie
approved these changes
Feb 19, 2025
|
@intel/llvm-gatekeepers This is ready to merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were reading the kernel arguments at kernel execution time, but kernel arguments are allowed to change between enqueuing and executing. Make sure to create a copy of kernel arguments ahead of time.
This was previously approved as a unified-runtime PR: oneapi-src/unified-runtime#2700