Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] sycl-trace is dependency of test-e2e #16753

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL] sycl-trace is dependency of test-e2e #16753

wants to merge 1 commit into from

Conversation

ldrumm
Copy link
Contributor

@ldrumm ldrumm commented Jan 23, 2025 •
edited
Loading 

 FAIL: SYCL :: Tracing/usm/queue_single_task_nullptr.cpp (2221 of 2265)
 Exit Code: 2

 Command Output (stdout):
 --
 [...]
 # .---command stderr------------
 # | error: unable to find `sycl-trace' in PATH: No such file or directory
 # `-----------------------------
 [...]

The test-e2e target depends on sycl-toolchain only, so I'm assuming we want sycl-toolchain to contain sycl-trace so that test-e2e picks up this dependency automatically.

@ldrumm ldrumm requested a review from a team as a code owner January 23, 2025 17:20
@ldrumm ldrumm requested a review from uditagarwal97 January 23, 2025 17:20
@ldrumm ldrumm force-pushed the test-dep-sycl-trace branch from 4324bf1 to 4dced79 Compare January 23, 2025 17:21
@uditagarwal97
Copy link
Contributor

Hi @ldrumm,
Where do you see this test failure Tracing/usm/queue_single_task_nullptr.cpp? I guess on CI it's working fine.
Overall, the fix LGTM, I just wanna locally verify it once before approving.

@ldrumm
Copy link
Contributor Author

ldrumm commented Jan 27, 2025

Hi @ldrumm, Where do you see this test failure Tracing/usm/queue_single_task_nullptr.cpp? I guess on CI it's working fine. Overall, the fix LGTM, I just wanna locally verify it once before approving.

Yes. queue_single_task_nullptr.cpp is where I saw the failure

@ldrumm
Copy link
Contributor Author

ldrumm commented Jan 27, 2025

Hi @ldrumm, Where do you see this test failure Tracing/usm/queue_single_task_nullptr.cpp? I guess on CI it's working fine. Overall, the fix LGTM, I just wanna locally verify it once before approving.

Yes. queue_single_task_nullptr.cpp is where I saw the failure

I misunderstood. I saw this on my local workstation after doing a ninja deploy-sycl-toolchain then a ninja check-sycl-e2e

@ldrumm
Copy link
Contributor Author

ldrumm commented Jan 27, 2025

That windows failure looks real. I'll have to track that down

@ldrumm
[SYCL] sycl-trace is dependency of test-e2e
f2210b9 
```
 FAIL: SYCL :: Tracing/usm/queue_single_task_nullptr.cpp (2221 of 2265)
 Exit Code: 2

 Command Output (stdout):
 --
 [...]
 # .---command stderr------------
 # | error: unable to find `sycl-trace' in PATH: No such file or directory
 # `-----------------------------
 [...]

```

The `test-e2e` target depends on `sycl-toolchain` only, so I'm assuming
we want `sycl-toolchain` to contain `sycl-trace` so that test-e2e picks
up this dependency automatically.
@ldrumm ldrumm force-pushed the test-dep-sycl-trace branch from 4dced79 to f2210b9 Compare March 13, 2025 15:47
@npmiller
Copy link
Contributor

That windows failure looks real. I'll have to track that down

sycl-trace isn't supported on Windows see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldrumm @uditagarwal97 @npmiller