[SYCLCompat] Optimize/(fix?) permute_sub_group_by_xor if logical_sub_group_size == 32
#16646
+27
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syclcompat::permute_sub_group_by_xor
was reported to flakily fail on L0. Closer inspection revealed that the implementation ofpermute_sub_group_by_xor
is incorrect for cases wherelogical_sub_group_size != 32
, which is one of the test cases. This implies that the test itself is wrong.In this PR we first optimize the part of the implementation that is valid assuming that Intel spirv builtins are correct (which is also the only case realistically a user will program): case
logical_sub_group_size == 32
, in order to:A follow on PR can fix the other cases where
logical_sub_group_size != 32
: this is better to do later, since