[SYCL] Implement backend content extension #16633

lbushi25 · 2025-01-14T21:24:19Z

Implement sycl_ext_oneapi_device_image_backend_content.

…shi25/llvm into device_image_backend_content

lbushi25 · 2025-01-17T18:00:57Z

sycl/test/abi/sycl_symbols_windows.dump

Most of the changes here are unrelated to the symbols I added. I suppose sometime in the past someone has modified this file manually which caused some of the symbols to get out of order.

sycl/test-e2e/DeviceImageBackendContent/CUDA_interop_test.cpp

sycl/include/sycl/kernel_bundle.hpp

sycl/test-e2e/DeviceImageBackendContent/CUDA_interop_test.cpp

sycl/test-e2e/DeviceImageBackendContent/L0_interop_test.cpp

steffenlarsen

LGTM!

lbushi25 · 2025-02-06T20:11:39Z

@intel/llvm-gatekeepers This looks ready for merge.

aelovikov-intel · 2025-02-06T20:31:46Z

sycl/test/extensions/DeviceImageBackendContent/negative_test.cpp

+#ifdef __cpp_lib_span
+  // expected-error@+1 {{no matching member function for call to 'ext_oneapi_get_backend_content_view'}}


This is misleading - there will be no error "emitted" as clang will complain if __cpp_lib_span isn't defined.

Yeah, this is both misleading and redundant as assuming we are using c++20, the macro should be defined.
I'll open a PR soon to remove.

aelovikov-intel · 2025-02-06T20:32:26Z

sycl/test-e2e/DeviceImageBackendContent/basic_test.cpp

@@ -0,0 +1,50 @@
+// RUN: %{build} -std=c++20 -o %t.out


We had some complains from Codeplay developers about such tests.

Can you point me to a thread where I can have a look at the concerns?

I don't have a link, try searching through git log with changes containing -std=++20

aelovikov-intel · 2025-02-06T23:23:49Z

[e2e-lin (Intel GEN12 Graphics with Level Zero])
Failed Tests (1):
SYCL :: DeviceImageBackendContent/OCL_interop_test.cpp

is failing (https://github.com/intel/llvm/actions/runs/13187415776) after this PR in post-commit. @lbushi25 , please address.

lbushi25 · 2025-02-06T23:38:51Z

[e2e-lin (Intel GEN12 Graphics with Level Zero])
Failed Tests (1):
SYCL :: DeviceImageBackendContent/OCL_interop_test.cpp
is failing (https://github.com/intel/llvm/actions/runs/13187415776) after this PR in post-commit. @lbushi25 , please address.

Looking into it.

lbushi25 · 2025-02-07T00:50:54Z

[e2e-lin (Intel GEN12 Graphics with Level Zero])
Failed Tests (1):
SYCL :: DeviceImageBackendContent/OCL_interop_test.cpp
is failing (https://github.com/intel/llvm/actions/runs/13187415776) after this PR in post-commit. @lbushi25 , please address.

PR to add the XFAIL: #16916

Implement backend content extension

464174d

lbushi25 had a problem deploying to WindowsCILock January 14, 2025 21:25 — with GitHub Actions Failure

lbushi25 temporarily deployed to WindowsCILock January 14, 2025 22:14 — with GitHub Actions Inactive

lbushi25 added 3 commits January 15, 2025 10:03

Merge branch 'device_image_backend_content' of https://github.com/lbu…

217270c

…shi25/llvm into device_image_backend_content

Add tests for extension

776a3ed

Merge branch 'intel:sycl' into device_image_backend_content

3080741

lbushi25 had a problem deploying to WindowsCILock January 15, 2025 21:08 — with GitHub Actions Error

lbushi25 added 2 commits January 15, 2025 13:10

Change extension spec status section

12bdf3f

Merge branch 'device_image_backend_content' of https://github.com/lbu…

a4f6372

…shi25/llvm into device_image_backend_content

lbushi25 had a problem deploying to WindowsCILock January 15, 2025 21:11 — with GitHub Actions Failure

lbushi25 temporarily deployed to WindowsCILock January 15, 2025 22:55 — with GitHub Actions Inactive

Add more tests and fix ABI related failures

c15a31a

lbushi25 had a problem deploying to WindowsCILock January 16, 2025 20:34 — with GitHub Actions Error

Add checks for span feature

0ba58c7

lbushi25 had a problem deploying to WindowsCILock January 16, 2025 20:37 — with GitHub Actions Failure

lbushi25 temporarily deployed to WindowsCILock January 16, 2025 21:09 — with GitHub Actions Inactive

Refactoring

50018cb

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 02:46 — with GitHub Actions Failure

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 03:16 — with GitHub Actions Error

More refactoring

b20f042

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 03:49 — with GitHub Actions Error

Formatting

2c7b110

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 04:18 — with GitHub Actions Failure

Merge branch 'intel:sycl' into device_image_backend_content

b884eec

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 16:16 — with GitHub Actions Failure

Add windows symbols

36f4095

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 17:59 — with GitHub Actions Error

lbushi25 commented Jan 17, 2025

View reviewed changes

Add check for std::span feature

5d4a6bf

lbushi25 had a problem deploying to WindowsCILock January 17, 2025 18:03 — with GitHub Actions Error

AlexeySachkov reviewed Feb 5, 2025

View reviewed changes

sycl/test-e2e/DeviceImageBackendContent/CUDA_interop_test.cpp Outdated Show resolved Hide resolved

Fix typo in CUDA test

a29db25

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 16:26 — with GitHub Actions Inactive

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 17:20 — with GitHub Actions Inactive

Update CUDA_interop_test.cpp

248fc93

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 18:36 — with GitHub Actions Inactive

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 19:18 — with GitHub Actions Inactive

Merge branch 'intel:sycl' into device_image_backend_content

c666340

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 20:53 — with GitHub Actions Inactive

lbushi25 had a problem deploying to WindowsCILock February 5, 2025 21:30 — with GitHub Actions Error

Fix compilation error in CUDA_interop_test.cpp

4ccce5a

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 21:36 — with GitHub Actions Inactive

lbushi25 temporarily deployed to WindowsCILock February 5, 2025 22:21 — with GitHub Actions Inactive

lbushi25 requested a review from AlexeySachkov February 6, 2025 06:13

AlexeySachkov approved these changes Feb 6, 2025

View reviewed changes

steffenlarsen reviewed Feb 6, 2025

View reviewed changes

Apply suggestions

2e4d7f8

lbushi25 had a problem deploying to WindowsCILock February 6, 2025 15:29 — with GitHub Actions Failure

steffenlarsen approved these changes Feb 6, 2025

View reviewed changes

lbushi25 had a problem deploying to WindowsCILock February 6, 2025 16:13 — with GitHub Actions Error

lbushi25 added 2 commits February 6, 2025 08:46

Fix compilation error in L0 test

9aa2184

Adjust symbols

6a88f93

lbushi25 temporarily deployed to WindowsCILock February 6, 2025 16:49 — with GitHub Actions Inactive

lbushi25 temporarily deployed to WindowsCILock February 6, 2025 17:37 — with GitHub Actions Inactive

againull merged commit 7e2f297 into intel:sycl Feb 6, 2025
16 checks passed

aelovikov-intel reviewed Feb 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL] Implement backend content extension #16633

[SYCL] Implement backend content extension #16633

lbushi25 commented Jan 14, 2025 •

edited

Loading

Uh oh!

lbushi25 Jan 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Uh oh!

lbushi25 commented Feb 6, 2025

Uh oh!

Uh oh!

aelovikov-intel Feb 6, 2025

Uh oh!

lbushi25 Feb 6, 2025

Uh oh!

aelovikov-intel Feb 6, 2025

Uh oh!

lbushi25 Feb 6, 2025

Uh oh!

aelovikov-intel Feb 6, 2025

Uh oh!

aelovikov-intel commented Feb 6, 2025

Uh oh!

lbushi25 commented Feb 6, 2025

Uh oh!

lbushi25 commented Feb 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

		#ifdef __cpp_lib_span
		// expected-error@+1 {{no matching member function for call to 'ext_oneapi_get_backend_content_view'}}

[SYCL] Implement backend content extension #16633

[SYCL] Implement backend content extension #16633

Conversation

lbushi25 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbushi25 Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

lbushi25 commented Feb 6, 2025

Uh oh!

Uh oh!

aelovikov-intel Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

lbushi25 Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

lbushi25 Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel commented Feb 6, 2025

Uh oh!

lbushi25 commented Feb 6, 2025

Uh oh!

lbushi25 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lbushi25 commented Jan 14, 2025 •

edited

Loading

lbushi25 Jan 17, 2025 •

edited

Loading

lbushi25 commented Feb 7, 2025 •

edited

Loading