Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement work group memory extension #15178

Merged
merged 97 commits into from
Oct 22, 2024

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Aug 22, 2024

Implement work group memory extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_memory.asciidoc
Two notes:

@lbushi25 lbushi25 marked this pull request as ready for review August 23, 2024 03:42
@lbushi25 lbushi25 requested review from a team as code owners August 23, 2024 03:42
sycl/include/sycl/handler.hpp Outdated Show resolved Hide resolved
@lbushi25
Copy link
Contributor Author

@intel/dpcpp-cfe-reviewers ping for review of the frontend changes and tests.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add FE tests for FE changes. Since you're adding a new type of argument with some special handling in the FE, I would add an AST test ensuring the expected arguments are generated and a CodeGen test for the change in integration header.

@elizabethandrews
Copy link
Contributor

Please add FE tests for FE changes. Since you're adding a new type of argument with some special handling in the FE, I would add an AST test ensuring the expected arguments are generated and a CodeGen test for the change in integration header.

Please add FE tests for FE changes. Since you're adding a new type of argument with some special handling in the FE, I would add an AST test ensuring the expected arguments are generated and a CodeGen test for the change in integration header.

My bad. I did not notice the test you added. No further changes are necessary

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers ping for merge.

@sarnex sarnex merged commit 60f6e16 into intel:sycl Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants