Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][COMPAT] defs.hpp update with Windows macros. SYCLCOMPAT_CHECK_ERROR added. #13027

Merged
merged 5 commits into from
Apr 16, 2024
Merged

[SYCL][COMPAT] defs.hpp update with Windows macros. SYCLCOMPAT_CHECK_ERROR added. #13027

merged 5 commits into from
Apr 16, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Mar 14, 2024

This PR:

  • unifies the names of the definitions in defs.hpp from sycl_compat to syclcompat
  • extends definitions to work with MSVC
  • Adds a macro to handle error codes from expressions that could throw sycl::exception.

@Alcpz Alcpz requested a review from a team as a code owner March 14, 2024 14:20
@Alcpz Alcpz mentioned this pull request Mar 14, 2024
Closed
@Alcpz Alcpz temporarily deployed to WindowsCILock March 14, 2024 15:21 — with GitHub Actions Inactive
@Alcpz Alcpz force-pushed the Alcpz/defs-update-2 branch from 1fe43c6 to 4fd7a29 Compare March 18, 2024 09:14
@Alcpz Alcpz temporarily deployed to WindowsCILock March 18, 2024 09:15 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock March 18, 2024 09:35 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock March 18, 2024 11:28 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock March 18, 2024 11:50 — with GitHub Actions Inactive
@Alcpz Alcpz mentioned this pull request Mar 18, 2024
Merged
AidanBeltonS
AidanBeltonS approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor changes needed, seems fine

sycl/doc/syclcompat/README.md Outdated Show resolved Hide resolved
sycl/doc/syclcompat/README.md Outdated Show resolved Hide resolved
@Alcpz Alcpz temporarily deployed to WindowsCILock April 15, 2024 13:18 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock April 15, 2024 13:38 — with GitHub Actions Inactive
@Alcpz
Copy link
Contributor Author

Alcpz commented Apr 16, 2024

@intel/llvm-gatekeepers This is ready to merge.

AWS CI check fails due to an unrelated test. Related issue: #13281

@sommerlukas sommerlukas merged commit 89eeb02 into intel:sycl Apr 16, 2024
13 checks passed
sommerlukas pushed a commit that referenced this pull request Apr 29, 2024
@Alcpz
[SYCL][COMPAT] Added helper functions to manage library and kernel rt…
de7413f 
… loads (#13053)

Marked as draft until #13027 gets merged.

- Adds functionality to SYCLcompat to load and unload libraries at
runtime.
- Adds helper functions to load kernel functors from said libraries.

Minor:
- Tests updated to match the style of the rest of the library
@Alcpz Alcpz deleted the Alcpz/defs-update-2 branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanBeltonS AidanBeltonS AidanBeltonS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alcpz @AidanBeltonS @sommerlukas