Fix cannot find arc-elf cross tool #398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuild/kbuild.sh: change arc cross tool name to arc-linux. This name is valid for all gcc versions Error: Cannot find arc-elf under https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/ kbuild/make.cross: change cross tool matching pattern. Avoid sparc-linux being used instead of arc-linux Error: lftpget -c https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/./14.2.0/x86_64-gcc-14.2.0-nolibc-sparc-linux.tar.xz Signed-off-by: Costin Constantin <[email protected]>
rli9
reviewed
Feb 13, 2025
| @@ -317,9 +317,9 @@ setup_cross_vars() | |||
| # for earlier gcc version, will failed to find arceb-elf for | |||
| # big endian arceb-elf tool chain | |||
| if is_config_enabled CONFIG_CPU_BIG_ENDIAN; then | |||
| crosstool=arceb-elf | |||
| crosstool=arceb-linux | |||
There was a problem hiding this comment.
Thanks a lot, the entry of gcc-14 is different than old ones. Looks can do mapping based on the compiler as well.
./gcc-9.3.0-nolibc/arceb-elf
./gcc-9.3.0-nolibc/arc-elf
./gcc-10.5.0-nolibc/arc-linux
./gcc-11.5.0-nolibc/arc-linux
./gcc-13.3.0-nolibc/arc-linux
./gcc-14.2.0-nolibc/arc-linux
Is it possible to check whether the compiler version is >= 10, then to use arc-linux? BTW: there's no arceb-linux, in higher version of gcc, it only has arc-linux
rli9
reviewed
Feb 13, 2025
| file=$(grep "${gcc_arch_pattern}\..*tar\.xz$" $list | grep "${gcc_version}" | tail -1) | ||
| # "arm-linux-gnueabi" to get single tool package which match exactly. Also, avoid wrong matching of cross | ||
| # tool for an other architecture like arc-linux.tar.xz and sparc-linux.tar.xz | ||
| file=$(grep "\-${gcc_arch_pattern}\.tar\.xz$" $list | grep "${gcc_version}" | tail -1) |
There was a problem hiding this comment.
thanks, can the pattern be "-${gcc_arch_pattern}..*tar.xz$, so it can be compatible to old compiler like gcc-9 to distinguish x86_64-gcc-9.3.0-nolibc_arm-linux-gnueabi.tar.xz and x86_64-gcc-9.3.0-nolibc_arm-linux-gnueabihf.tar.xz?
rli9
added a commit
that referenced
this pull request
Mar 17, 2025
./gcc-9.3.0-nolibc/arceb-elf ./gcc-9.3.0-nolibc/arc-elf ./gcc-10.5.0-nolibc/arc-linux ./gcc-11.5.0-nolibc/arc-linux ./gcc-13.3.0-nolibc/arc-linux ./gcc-14.2.0-nolibc/arc-linux Reported-by: Costin Costinctin <[email protected]> Link: #398 Signed-off-by: Philip Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kbuild/kbuild.sh: change arc cross tool name to arc-linux. This name is valid for all gcc versions
Error: Cannot find arc-elf under https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/
kbuild/make.cross: change cross tool matching pattern. Avoid sparc-linux being used instead of arc-linux
Error: lftpget -c https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/./14.2.0/x86_64-gcc-14.2.0-nolibc-sparc-linux.tar.xz