va: Add VA_SURFACE_ATTRIB_USAGE_HINT_SCANOUT #820
Conversation
|
This can be used to tell the driver set scanout surface. XE DMA DRM render case required this. Signed-off-by: Cheah, Vincent Beng Keat <[email protected]>
The scanout surface only required for XE DMA DRM render case. I have tested this on MTL on XE. https://github.com/vcheah/libraries.media.vpl.tools/tree/scanout If scanout not set, drmModeAddFB2WithModifiers() will fail (-EINVAL). The kernel message error points to https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/xe/display/intel_fb_bo.c#L23 |
the problem is: if not set ,will cause issue, then this PR break the compatibility . |
Do you have any other good recommendation in mind? The problem is when the created surfaces and had undergo VM_BIND operation, The list_empty(&bo->ttm.base.gpuva.list) will never be empty, hence, it will always encounters the failing case. |
The flags is actually only required for DRM render case in order for render to work. For XE native weston10 case, I have checked (MTL/RPL), sometime ago, having the scanout surface set or NOT, the render output is correct. However, weston10 + scanout surface, it seems to suffer some performance degradation based on some early data that I've collected sometime ago (on ADL). |
|
Closing the MR. Track this: intel/media-driver#1822 |
This can be used to tell the driver set scanout surface. XE DMA DRM render case required this.