Add trace for vaExportSurfaceHandle #724
Conversation
MicroYY
force-pushed
the
trace_export
branch
6 times, most recently
from
5724592
to
c87aa01
Compare
|
|
||
| VADRMPRIMESurfaceDescriptor *desc = (VADRMPRIMESurfaceDescriptor *)descriptor; | ||
|
|
||
| va_TraceMsg(trace_ctx, "\tfourcc = %u\n", desc->fourcc); |
There was a problem hiding this comment.
This will crash if descriptor is NULL. Parent function (vaExportSurfaceHandle) does not check that (and it should not). Add check here, please.
There was a problem hiding this comment.
Fixed in last version, see line 6343 above.
va/va_trace.c
Outdated
| } | ||
|
|
||
| DPY2TRACE_VIRCTX_EXIT(pva_trace); | ||
| } |
There was a problem hiding this comment.
add empty line in end of file
| va_TraceMsg(trace_ctx, "\tmemType = 0x%08x\n", memType); | ||
| va_TraceMsg(trace_ctx, "\tflags = 0x%08x\n", flags); | ||
|
|
||
| VADRMPRIMESurfaceDescriptor *desc = (VADRMPRIMESurfaceDescriptor *)descriptor; |
There was a problem hiding this comment.
As noted at
Lines 4054 to 4055 in 984dfee
You can't assume it's VADRMPRIMESurfaceDescriptor without checking memType.
There was a problem hiding this comment.
Fixed in last version, see line 6337 above.
| va_TraceMsg(trace_ctx, "\tmemType = 0x%08x\n", memType); | ||
| va_TraceMsg(trace_ctx, "\tflags = 0x%08x\n", flags); | ||
|
|
||
| VADRMPRIMESurfaceDescriptor *desc = (VADRMPRIMESurfaceDescriptor *)descriptor; |
There was a problem hiding this comment.
Fixed in last version, see line 6337 above.
|
|
||
| VADRMPRIMESurfaceDescriptor *desc = (VADRMPRIMESurfaceDescriptor *)descriptor; | ||
|
|
||
| va_TraceMsg(trace_ctx, "\tfourcc = %u\n", desc->fourcc); |
There was a problem hiding this comment.
Fixed in last version, see line 6343 above.
XinfengZhang
force-pushed
the
trace_export
branch
from
84d007c
to
67166dc
Compare
No description provided.