Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework device names #682

Merged
merged 19 commits into from
Jun 8, 2023
Merged

Rework device names #682

merged 19 commits into from
Jun 8, 2023

Commits on Jun 6, 2023

  1. va: split the legacy opendriver to separate function 

    Move all the existing open driver code into a legacy function. It will
soon be replaced (in gradual non-regressing manner) with a new shorter
and more coherent solution.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    06021b8 View commit details
    Browse the repository at this point in the history

  2. va: add vaGetDriverNames() internal ABI 

    The current GetDriver API is rather fragile and bonkers.

In particular it does a two-step pass - number vs names. That in itself
is not great, since it assumes the devices do not change in between.
Additionally there is the assumption of index X will match device (name)
X, which does not hold true.

The most prominent issue is the inability to provide accurate number and
list of names.

Instead, we can have a single API, that provides both pieces of data in
one go - shorter and simpler code - in reliable manner.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    888e499 View commit details
    Browse the repository at this point in the history

  3. drm: split DisplayConnect into separate function 

    This way we can reuse it with the follow-up patches.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    52b10da View commit details
    Browse the repository at this point in the history

  4. drm: implement vaGetDriverNames 

    v2: Add WSL case

v3: Drop sentinel, use ARRAY_SIZE

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    1fff2a1 View commit details
    Browse the repository at this point in the history

  5. drm: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d0fc7ba View commit details
    Browse the repository at this point in the history

  6. android: split DisplayConnect into separate function 

    This way we can reuse it with the follow-up patches.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    fa3d677 View commit details
    Browse the repository at this point in the history

  7. android: implement vaGetDriverNames 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    adac8db View commit details
    Browse the repository at this point in the history

  8. android: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5c52fc1 View commit details
    Browse the repository at this point in the history

  9. wayland: implement vaGetDriverNames 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    358e927 View commit details
    Browse the repository at this point in the history

  10. wayland: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5831118 View commit details
    Browse the repository at this point in the history

  11. win32: implement vaGetDriverNames 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    bad7c1b View commit details
    Browse the repository at this point in the history

  12. win32: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    db7c872 View commit details
    Browse the repository at this point in the history

  13. va/x11/va_fglrx: remove some dead code 

    Drop a bunch of set but unused variables and associated dead code.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b7abe7c View commit details
    Browse the repository at this point in the history

  14. va/x11/va_nvctrl: remove some dead code 

    Drop a bunch of set but unused variables and associated dead code.

Note: if we are to remove the version handling, then 2/3 of the code in
this file will become unused. Yet it's fairly subtle code and there's a
notable chance of detection breaking if we remove it.

So keep the variables around and (void) prefix them so the compiler does
not warn.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8e62bc1 View commit details
    Browse the repository at this point in the history

  15. x11: implement vaGetDriverNames 

    v2: Drop sentinel, use ARRAY_SIZE

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7f94dbd View commit details
    Browse the repository at this point in the history

  16. x11: allow disabling DRI3 via LIBVA_DRI3_DISABLE env var 

    There are some corner cases where DRI3 does not work correctly. While
bug reports are appreciated, this enables users to get back to their
machines in meaningful way - aka w/o having to rebuild libva.

Signed-off-by: Emil Velikov <[email protected]>
    @evelikov-work @evelikov
    evelikov-work authored and evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    05e0d67 View commit details
    Browse the repository at this point in the history

  17. x11: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2a615a1 View commit details
    Browse the repository at this point in the history

  18. drm: remove no longer used helpers 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2b6b7aa View commit details
    Browse the repository at this point in the history

  19. va: remove legacy code paths 

    Signed-off-by: Emil Velikov <[email protected]>
    @evelikov
    evelikov committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    89b15d1 View commit details
    Browse the repository at this point in the history