query the caps before calling vaCopy #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Zhang <[email protected]>
fenhu
approved these changes
Apr 26, 2021
dvrogozh
reviewed
Apr 26, 2021
| printf("VPP is not supported by driver\n"); | ||
| assert(0); | ||
| } | ||
| /* Check whether vaCopy is supported by driver */; |
There was a problem hiding this comment.
I would consider adding new attribs reporting in vainfo.
| va_status = vaGetDisplayAttributes(va_dpy, &va_disp_attr, 1); | ||
|
|
||
| CHECK_VASTATUS(va_status, "vaGetDisplayAttrib"); | ||
| if(va_disp_attr.value == VA_ATTRIB_NOT_SUPPORTED || va_disp_attr.value == 0) |
There was a problem hiding this comment.
at line 540 we do:
option.bits.va_copy_mode = g_copy_method; // VA_COPY_MODE_BALANCE;
It would be better :
- to make it parametrized via cmd line:
- to check if the specified mode (even if it's hardcoded) matches attributes returned from vaGetDisplayAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to intel/libva#513
Signed-off-by: Carl Zhang [email protected]